[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/22] tcg/tci: Split out target constraints to tcg-target
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 07/22] tcg/tci: Split out target constraints to tcg-target-con-str.h |
Date: |
Tue, 19 Jan 2021 23:19:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/15/21 10:04 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci/tcg-target-con-str.h | 11 +++++++++++
> tcg/tci/tcg-target.h | 2 ++
> tcg/tci/tcg-target.c.inc | 14 --------------
> 3 files changed, 13 insertions(+), 14 deletions(-)
> create mode 100644 tcg/tci/tcg-target-con-str.h
>
> diff --git a/tcg/tci/tcg-target-con-str.h b/tcg/tci/tcg-target-con-str.h
> new file mode 100644
> index 0000000000..87c0f19e9c
> --- /dev/null
> +++ b/tcg/tci/tcg-target-con-str.h
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Define TCI target-specific operand constraints.
> + * Copyright (c) 2021 Linaro
> + */
> +
> +/*
> + * Define constraint letters for register sets:
> + * REGS(letter, register_mask)
> + */
> +REGS('r', MAKE_64BIT_MASK(0, TCG_TARGET_NB_REGS))
> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h
> index bb784e018e..ab832aecc3 100644
> --- a/tcg/tci/tcg-target.h
> +++ b/tcg/tci/tcg-target.h
> @@ -207,4 +207,6 @@ static inline void tb_target_set_jmp_target(uintptr_t
> tc_ptr, uintptr_t jmp_rx,
> /* no need to flush icache explicitly */
> }
>
> +#define TCG_TARGET_CON_STR_H
> +
> #endif /* TCG_TARGET_H */
> diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc
> index 9c45f5f88f..c913d85c37 100644
> --- a/tcg/tci/tcg-target.c.inc
> +++ b/tcg/tci/tcg-target.c.inc
> @@ -384,20 +384,6 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int
> type,
> return true;
> }
>
> -/* Parse target specific constraints. */
> -static const char *target_parse_constraint(TCGArgConstraint *ct,
> - const char *ct_str, TCGType type)
> -{
> - switch (*ct_str++) {
> - case 'r':
> - ct->regs = BIT(TCG_TARGET_NB_REGS) - 1;
> - break;
Easy one :)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> - default:
> - return NULL;
> - }
> - return ct_str;
> -}
- Re: [PATCH v2 03/22] tcg/i386: Split out target constraints to tcg-target-con-str.h, (continued)
[PATCH v2 05/22] tcg/aarch64: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15
[PATCH v2 06/22] tcg/ppc: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15
[PATCH v2 04/22] tcg/arm: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15
[PATCH v2 07/22] tcg/tci: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15
[PATCH v2 02/22] tcg/i386: Move constraint type check to tcg_target_const_match, Richard Henderson, 2021/01/15
[PATCH v2 09/22] tcg/riscv: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15
[PATCH v2 11/22] tcg/sparc: Split out target constraints to tcg-target-con-str.h, Richard Henderson, 2021/01/15