[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fuzz: ignore address_space_map is_write flag
From: |
Darren Kenny |
Subject: |
Re: [PATCH] fuzz: ignore address_space_map is_write flag |
Date: |
Wed, 20 Jan 2021 10:11:02 +0000 |
On Wednesday, 2021-01-20 at 01:02:55 -05, Alexander Bulekov wrote:
> We passed an is_write flag to the fuzz_dma_read_cb function to
> differentiate between the mapped DMA regions that need to be populated
> with fuzzed data, and those that don't. We simply passed through the
> address_space_map is_write parameter. The goal was to cut down on
> unnecessarily populating mapped DMA regions, when they are not read
> from.
>
> Unfortunately, nothing precludes code from reading from regions mapped
> with is_write=true. For example, see:
> https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg04729.html
>
> This patch removes the is_write parameter to fuzz_dma_read_cb. As a
> result, we will fill all mapped DMA regions with fuzzed data, ignoring
> the specified transfer direction.
>
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>