[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hmp: remove "change vnc TARGET" command
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/3] hmp: remove "change vnc TARGET" command |
Date: |
Wed, 20 Jan 2021 09:24:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/20/21 8:42 AM, Paolo Bonzini wrote:
> The HMP command \"change vnc TARGET\" is messy:
>
> - it takes an ugly shortcut to determine if the option has an "id",
> with incorrect results if "id=" is not preceded by an unescaped
> comma.
>
> - it deletes the existing QemuOpts and does not try to rollback
> if the parsing fails (which is not causing problems, but only due to
> how VNC options are parsed)
>
> - because it uses the same parsing function as "-vnc", it forces
> the latter to not support "-vnc help".
>
> On top of this, it uses a deprecated QMP command, thus getting in
> the way of removing the QMP command. Since the usecase for the
> command is not clear, just remove it and send "change vnc password"
> directly to the QMP "change-vnc-password" command.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> docs/system/removed-features.rst | 6 ++++++
> hmp-commands.hx | 6 ------
> monitor/hmp-cmds.c | 7 +++++--
> 3 files changed, 11 insertions(+), 8 deletions(-)
HMP is not promised to be stable, so no deprecation period required.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help", Paolo Bonzini, 2021/01/20
- [PATCH 1/3] hmp: remove "change vnc TARGET" command, Paolo Bonzini, 2021/01/20
- Re: [PATCH 1/3] hmp: remove "change vnc TARGET" command,
Eric Blake <=
- [PATCH 2/3] qmp: remove deprecated "change" command, Paolo Bonzini, 2021/01/20
- [PATCH 3/3] vnc: support "-vnc help", Paolo Bonzini, 2021/01/20
- Re: [PATCH 0/3] vnc: remove "change vnc TARGET" and QMP change command, support "-vnc help", Gerd Hoffmann, 2021/01/21