[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/8] iotests.py: fix qemu_tool_pipe_and_status()
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 3/8] iotests.py: fix qemu_tool_pipe_and_status() |
Date: |
Wed, 20 Jan 2021 19:58:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 11/30/20 7:40 AM, Vladimir Sementsov-Ogievskiy wrote:
> qemu_img_args variable is unrelated here. We should print just args.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/iotests.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index bcd4fe5b6f..5ebe25e063 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -101,9 +101,8 @@ def qemu_tool_pipe_and_status(tool: str, args:
> Sequence[str],
> universal_newlines=True)
> output = subp.communicate()[0]
> if subp.returncode < 0:
> - sys.stderr.write('%s received signal %i: %s\n'
> - % (tool, -subp.returncode,
> - ' '.join(qemu_img_args + list(args))))
> + cmd = ' '.join(args)
> + sys.stderr.write(f'{tool} received signal {-subp.returncode}:
> {cmd}\n')
> return (output, subp.returncode)
>
> def qemu_img_pipe_and_status(*args: str) -> Tuple[str, int]:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 3/8] iotests.py: fix qemu_tool_pipe_and_status(),
Eric Blake <=