[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 4/7] coroutine: add libucontext as external library
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v6 4/7] coroutine: add libucontext as external library |
Date: |
Thu, 21 Jan 2021 16:17:03 +0000 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Mon, Jan 04, 2021 at 06:20:52PM -0800, Joelle van Dyne wrote:
> iOS does not support ucontext natively for aarch64 and the sigaltstack is
> also unsupported (even worse, it fails silently, see:
> https://openradar.appspot.com/13002712 )
>
> As a workaround we include a library implementation of ucontext and add it
> as a build option.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> ---
> configure | 23 ++++++++++++++++++++---
> meson.build | 11 ++++++++++-
> util/coroutine-ucontext.c | 9 +++++++++
> .gitmodules | 3 +++
> meson_options.txt | 2 ++
> subprojects/libucontext | 1 +
> 6 files changed, 45 insertions(+), 4 deletions(-)
> create mode 160000 subprojects/libucontext
> diff --git a/.gitmodules b/.gitmodules
> index 2bdeeacef8..4f02eed79a 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -64,3 +64,6 @@
> [submodule "roms/vbootrom"]
> path = roms/vbootrom
> url = https://git.qemu.org/git/vbootrom.git
> +[submodule "libucontext"]
> + path = subprojects/libucontext
> + url = https://github.com/utmapp/libucontext.git
Using libucontext looks like a good idea to me, but I noticed that
this is a pointing to a fork of the main libucontext project at
https://github.com/kaniini/libucontext
The main project appears 100's of commits ahead of the utmapp fork
What is in the utmapp fork that isn't present in the primary libucontext
repo ? I think if we're going to use libucontext we will want to point
to the primary project, and this means anything custom in the fork will
need to get submitted upstream. Maybe you've already started doing that
making this a non-issue ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v6 0/7] iOS and Apple Silicon host support, Joelle van Dyne, 2021/01/04
- [PATCH v6 1/7] configure: option to disable host block devices, Joelle van Dyne, 2021/01/04
- [PATCH v6 2/7] configure: cross-compiling with empty cross_prefix, Joelle van Dyne, 2021/01/04
- [PATCH v6 6/7] slirp: update build flags for iOS resolv fix, Joelle van Dyne, 2021/01/04
- [PATCH v6 4/7] coroutine: add libucontext as external library, Joelle van Dyne, 2021/01/04
- Re: [PATCH v6 4/7] coroutine: add libucontext as external library,
Daniel P . Berrangé <=
- [PATCH v6 5/7] configure: cross compile should use x86_64 cpu_family, Joelle van Dyne, 2021/01/04
- [PATCH v6 3/7] qemu: add support for iOS host, Joelle van Dyne, 2021/01/04
- [PATCH v6 7/7] block: check availablity for preadv/pwritev on mac, Joelle van Dyne, 2021/01/04