[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing |
Date: |
Fri, 22 Jan 2021 18:58:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/20/21 4:28 AM, Taylor Simpson wrote:
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org
Missing trailing '>' ;)
> ---
> target/hexagon/printinsn.h | 28 +++++++++
> target/hexagon/printinsn.c | 146
> +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 174 insertions(+)
> create mode 100644 target/hexagon/printinsn.h
> create mode 100644 target/hexagon/printinsn.c
>
> diff --git a/target/hexagon/printinsn.h b/target/hexagon/printinsn.h
> new file mode 100644
> index 0000000..d6331e0
> --- /dev/null
> +++ b/target/hexagon/printinsn.h
> @@ -0,0 +1,28 @@
> +/*
> + * Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights
> Reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef HEXAGON_PRINTINSN_H
> +#define HEXAGON_PRINTINSN_H
> +
> +#include "qemu/osdep.h"
> +#include "insn.h"
> +
> +extern void snprint_a_pkt_disas(GString *buf, Packet *pkt, uint32_t *words,
> + target_ulong pc);
> +extern void snprint_a_pkt_debug(GString *buf, Packet *pkt);
No need to declare prototypes in header with 'extern'...
(also noticed in other patches).
I'm surprise checkpatch.pl doesn't warn about this.
> +
> +#endif
- [PATCH v7 11/35] Hexagon (target/hexagon) register fields, (continued)
- [PATCH v7 05/35] Hexagon (disas) disassembler, Taylor Simpson, 2021/01/19
- [PATCH v7 35/35] Add Dockerfile for hexagon, Taylor Simpson, 2021/01/19
- [PATCH v7 08/35] Hexagon (target/hexagon) GDB Stub, Taylor Simpson, 2021/01/19
- [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing, Taylor Simpson, 2021/01/19
- Re: [PATCH v7 14/35] Hexagon (target/hexagon) instruction printing,
Philippe Mathieu-Daudé <=
- [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions, Taylor Simpson, 2021/01/19
[PATCH v7 19/35] Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics, Taylor Simpson, 2021/01/19
[PATCH v7 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2021/01/19
[PATCH v7 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions, Taylor Simpson, 2021/01/19
[PATCH v7 18/35] Hexagon (target/hexagon/imported) arch import, Taylor Simpson, 2021/01/19