[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/11] osdep: build with non-working system() function
From: |
Joelle van Dyne |
Subject: |
Re: [PATCH v7 05/11] osdep: build with non-working system() function |
Date: |
Fri, 22 Jan 2021 19:18:36 -0800 |
Unfortunately, this doesn't work for iOS, which defines system() but
throws a compile time error if you try to call it.
-j
On Fri, Jan 22, 2021 at 3:17 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 22 Jan 2021 at 23:12, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Fri, 22 Jan 2021 at 20:13, Joelle van Dyne <j@getutm.app> wrote:
> > >
> > > Build without error on hosts without a working system(). An assertion
> > > will trigger if system() is called.
> > >
> > > Signed-off-by: Joelle van Dyne <j@getutm.app>
> >
> > configure | 19 +++++++++++++++++++
> >
> > Can we do the "does system() exist?" check in meson.build ?
> > Untested, but looking at the existing check for "does gettid() exist?"
> > it should be two lines:
> >
> > has_system = cc.has_function('system')
> >
> > and then later:
> >
> > config_host_data.set('HAVE_SYSTEM_FUNCTION', has_system)
>
> ...looking at how we do the HAVE_FOO_H settings, I think we
> can just collapse this into one line:
>
> config_host_data.set('HAVE_SYSTEM_FUNCTION', cc.has_function('system'))
>
> thanks
> -- PMM
- [PATCH v7 03/11] configure: check for sys/disk.h, (continued)
- [PATCH v7 03/11] configure: check for sys/disk.h, Joelle van Dyne, 2021/01/22
- [PATCH v7 06/11] darwin: remove redundant dependency declaration, Joelle van Dyne, 2021/01/22
- [PATCH v7 07/11] darwin: fix cross-compiling for Darwin, Joelle van Dyne, 2021/01/22
- [PATCH v7 08/11] configure: cross compile should use x86_64 cpu_family, Joelle van Dyne, 2021/01/22
- [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/22
- Re: [PATCH v7 05/11] osdep: build with non-working system() function,
Joelle van Dyne <=
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/23
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Paolo Bonzini, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Joelle van Dyne, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Paolo Bonzini, 2021/01/25
- Re: [PATCH v7 05/11] osdep: build with non-working system() function, Peter Maydell, 2021/01/26
[PATCH v7 09/11] block: check availablity for preadv/pwritev on mac, Joelle van Dyne, 2021/01/22
[PATCH v7 11/11] darwin: remove 64-bit build detection on 32-bit OS, Joelle van Dyne, 2021/01/22
[PATCH v7 10/11] darwin: detect CoreAudio for build, Joelle van Dyne, 2021/01/22