[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] hw/sd: sd: Support CMD59 for SPI mode
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 2/9] hw/sd: sd: Support CMD59 for SPI mode |
Date: |
Sun, 24 Jan 2021 21:10:59 +0100 |
From: Bin Meng <bin.meng@windriver.com>
After the card is put into SPI mode, CRC check for all commands
including CMD0 will be done according to CMD59 setting. But this
command is currently unimplemented. Simply allow the decoding of
CMD59, but the CRC remains unchecked.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Tested-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Pragnesh Patel <pragnesh.patel@sifive.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210123104016.17485-5-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/sd.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 4375ed5b8b2..bfea5547d53 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1517,18 +1517,12 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
SDRequest req)
if (!sd->spi) {
goto bad_cmd;
}
- goto unimplemented_spi_cmd;
+ return sd_r1;
default:
bad_cmd:
qemu_log_mask(LOG_GUEST_ERROR, "SD: Unknown CMD%i\n", req.cmd);
return sd_illegal;
-
- unimplemented_spi_cmd:
- /* Commands that are recognised but not yet implemented in SPI mode.
*/
- qemu_log_mask(LOG_UNIMP, "SD: CMD%i not implemented in SPI mode\n",
- req.cmd);
- return sd_illegal;
}
qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state\n", req.cmd);
--
2.26.2
- [PULL 0/9] SD/MMC patches for 2021-01-24, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 1/9] hw/sd: ssi-sd: Fix incorrect card response sequence, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 2/9] hw/sd: sd: Support CMD59 for SPI mode,
Philippe Mathieu-Daudé <=
- [PULL 3/9] hw/sd: sd: Drop sd_crc16(), Philippe Mathieu-Daudé, 2021/01/24
- [PULL 4/9] util: Add CRC16 (CCITT) calculation routines, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 5/9] hw/sd: ssi-sd: Suffix a data block with CRC16, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 6/9] hw/sd: ssi-sd: Add a state representing Nac, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 7/9] hw/sd: ssi-sd: Fix the wrong command index for STOP_TRANSMISSION, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 8/9] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer, Philippe Mathieu-Daudé, 2021/01/24
- [PULL 9/9] hw/sd: sd.h: Cosmetic change of using spaces, Philippe Mathieu-Daudé, 2021/01/24
- Re: [PULL 0/9] SD/MMC patches for 2021-01-24, Peter Maydell, 2021/01/25