[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/12] meson: Restrict emulation code
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 08/12] meson: Restrict emulation code |
Date: |
Mon, 25 Jan 2021 16:12:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/25/21 4:09 PM, Philippe Mathieu-Daudé wrote:
> On 1/22/21 9:44 PM, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> Cc: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> meson.build | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index 396ea3aa19b..b5afa2923b3 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -1809,16 +1809,18 @@
>> qemuutil = declare_dependency(link_with: libqemuutil,
>> sources: genh + version_res)
>>
>> -decodetree = generator(find_program('scripts/decodetree.py'),
>> - output: 'decode-@BASENAME@.c.inc',
>> - arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o',
>> '@OUTPUT@'])
>> +if have_system or have_user
>
> Maybe better as:
>
> if not get_option('tcg').disabled()
>
> And even clearer as:
>
> if get_option('tcg').enabled()
>
> assuming enabled would be "auto" or "yes".
^ this comment is only for the decodetree generator, not for
the target/ directory ;)
>
>> + decodetree = generator(find_program('scripts/decodetree.py'),
>> + output: 'decode-@BASENAME@.c.inc',
>> + arguments: ['@INPUT@', '@EXTRA_ARGS@', '-o',
>> '@OUTPUT@'])
>> + subdir('libdecnumber')
>> + subdir('target')
>> +endif
>>
>> subdir('audio')
>> subdir('io')
>> subdir('chardev')
>> subdir('fsdev')
>> -subdir('libdecnumber')
>> -subdir('target')
>> subdir('dump')
>>
>> block_ss.add(files(
>>
>
- [PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation, (continued)
- [PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 04/12] meson: Do not build optional libraries by default, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 05/12] meson: Restrict block subsystem processing, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 06/12] meson: Merge trace_events_subdirs array, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 07/12] meson: Restrict some trace event directories to user/system emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 08/12] meson: Restrict emulation code, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 10/12] qapi/meson: Remove QMP from user-mode emulation, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 11/12] qapi/meson: Restrict system-mode specific modules, Philippe Mathieu-Daudé, 2021/01/22
- [PATCH v2 12/12] qapi/meson: Restrict UI module to system emulation and tools, Philippe Mathieu-Daudé, 2021/01/22
- Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Paolo Bonzini, 2021/01/23
- Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Alex Bennée, 2021/01/26