Re: [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers

[Philippe Mathieu-Daudé]

On 1/22/21 10:50 PM, Taylor Simpson wrote:
>> -----Original Message-----
>> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
>> Behalf Of Philippe Mathieu-Daudé
>> Sent: Friday, January 22, 2021 2:30 PM
>> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
>> Cc: richard.henderson@linaro.org; alex.bennee@linaro.org;
>> laurent@vivier.eu; ale@rev.ng; Brian Cain <bcain@quicinc.com>
>> Subject: Re: [PATCH v7 07/35] Hexagon (target/hexagon) scalar core helpers
>>
>> Hi Taylor,
>>
>> On 1/20/21 4:28 AM, Taylor Simpson wrote:
>>> The majority of helpers are generated.  Define the helper functions
>> needed
>>> then include the generated file
>>>
>>> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
>>> ---
>>>  target/hexagon/helper.h    |   85 ++++
>>>  target/hexagon/op_helper.c | 1066
>> ++++++++++++++++++++++++++++++++++++++++++++
>>>  2 files changed, 1151 insertions(+)
>>>  create mode 100644 target/hexagon/helper.h
>>>  create mode 100644 target/hexagon/op_helper.c
...

>> ../target/hexagon/op_helper.c:201:27: error: format ‘%lx’ expects
>> argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’
>> {aka ‘long long unsigned int’} [-Werror=format=]
>>   201 |             HEX_DEBUG_LOG("\tmemd[0x" TARGET_FMT_lx "] = %lu
>> (0x%016lx)\n",
>>       |                           ^~~~~~~~~~~
>> ......
>>   204 |                           env->mem_log_stores[slot].data64);
>>       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>       |                                                    |
>>       |                                                    uint64_t {aka
>> long long unsigned int}
>> ../target/hexagon/internal.h:28:22: note: in definition of macro
>> ‘HEX_DEBUG_LOG’
>>    28 |             qemu_log(__VA_ARGS__); \
>>       |                      ^~~~~~~~~~~
> 
> Strange, I don't see those errors.  I tested it on Ubuntu 16 with gcc 4.8 and 
> 5.5 and Ubuntu 20 with gcc 9.3.  Could you tell me more about the system you 
> are building on?

Raspberry Pi 2, but it is probably reproducible on all 32-bit hosts
(QEMU provides Docker images for cross-building win32, armel, armhf).

> 
> All of those HEX_DEBUG_LOG calls should be #ifdef'ed out.  Did you change the 
> definition of HEX_DEBUG in internal.h?  Even when I set HEX_DEBUG to 1, I 
> don't see these errors.

I haven't changed anything.

Regards,

Phil.