[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/12] buildsys: Do not build various objects if not neces
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary |
Date: |
Tue, 26 Jan 2021 20:38:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/26/21 5:09 PM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>
>> On 1/26/21 3:57 PM, Alex Bennée wrote:
>>>
>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>
>>>> In this series we deselect a bunch of features when they
>>>> not required, so less objects are built.
>>>>
>>>> While this reduce pressure on CI and slow systems, this is
>>>> particularly helpful for developers regularly testing multiple
>>>> build configurations.
>>>>
>>>> All CI tests pass:
>>>> https://gitlab.com/philmd/qemu/-/pipelines/245654160
>>>>
>>>> Supersedes: <20210120151916.1167448-1-philmd@redhat.com>
>>>
>>> Series looks good to me but I guess you need some sub-system feedback.
>>
>> Yeah, I will wait for Markus feedback on qapi/ before respining (with
>> target/ fix), ...
>
> Maybe I'm naive today, but to me this looks like a case of "if it still
> builds, it's fine".
>
> Anything in particular you want my feedback for?
You are listed as qapi/ maintainer with Michael :)
QAPI
M: Markus Armbruster <armbru@redhat.com>
M: Michael Roth <michael.roth@amd.com>
S: Supported
F: qapi/
If it is fine to you, then I'll respin addressing Paolo's comments.
Thanks :)
Phil.
- Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation, (continued)
[PATCH v2 10/12] qapi/meson: Remove QMP from user-mode emulation, Philippe Mathieu-Daudé, 2021/01/22
[PATCH v2 11/12] qapi/meson: Restrict system-mode specific modules, Philippe Mathieu-Daudé, 2021/01/22
[PATCH v2 12/12] qapi/meson: Restrict UI module to system emulation and tools, Philippe Mathieu-Daudé, 2021/01/22
Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Paolo Bonzini, 2021/01/23
Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Alex Bennée, 2021/01/26
Re: [PATCH v2 00/12] buildsys: Do not build various objects if not necessary, Paolo Bonzini, 2021/01/29