[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create()
From: |
Joel Stanley |
Subject: |
Re: [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create() |
Date: |
Thu, 28 Jan 2021 00:46:48 +0000 |
On Tue, 26 Jan 2021 at 17:14, Cédric Le Goater <clg@kaod.org> wrote:
>
> and reuse pnv_bmc_set_pnor() to share the setting of the PNOR.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/pnv_bmc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c
> index 67ebb16c4d5f..86d16b493539 100644
> --- a/hw/ppc/pnv_bmc.c
> +++ b/hw/ppc/pnv_bmc.c
> @@ -260,13 +260,8 @@ IPMIBmc *pnv_bmc_create(PnvPnor *pnor)
> Object *obj;
>
> obj = object_new(TYPE_IPMI_BMC_SIMULATOR);
> - object_ref(OBJECT(pnor));
> - object_property_add_const_link(obj, "pnor", OBJECT(pnor));
I assume it's ok to move the link set to after the realise of the BMC object?
> qdev_realize(DEVICE(obj), NULL, &error_fatal);
> -
> - /* Install the HIOMAP protocol handlers to access the PNOR */
> - ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM,
> - &hiomap_netfn);
> + pnv_bmc_set_pnor(IPMI_BMC(obj), pnor);
>
> return IPMI_BMC(obj);
> }
> --
> 2.26.2
>
>
Re: [PATCH 4/7] ppc/pnv: Simplify pnv_bmc_create(), David Gibson, 2021/01/27
[PATCH 1/7] ppc/pnv: Add trace events for PCI event notification, Cédric Le Goater, 2021/01/26
[PATCH 7/7] ppc/pnv: Introduce a LPC FW memory region attribute to map the PNOR, Cédric Le Goater, 2021/01/26