Re: [PATCH] tests: Replace deprecated ASN1 code

[Daniel P . Berrangé]

On Fri, Jan 29, 2021 at 12:35:59PM +0100, Stefan Weil wrote:
> Am 29.01.21 um 11:06 schrieb Daniel P. Berrangé:
> 
> > On Thu, Jan 28, 2021 at 06:15:23PM +0100, Stefan Weil wrote:
> > > This fixes several compiler warnings on MacOS with Homebrew.
> > Could you give an example of the warnings seen as I'm wondering
> > why we won't have seen them already on other platforms ?
> 
> 
> Here they are (at least the first few, as the list is lengthy). I used
> 
> ../configure --enable-sanitizers --enable-debug
> --extra-cflags=-I/opt/homebrew/include --enable-cocoa
> 
> Maybe the warnings were enabled by --enable-debug.
> 
> Regards, Stefan
> 
> 
> % ninja
> [4696/4942] Compiling C object
> tests/test-crypto-tlscredsx509.p/test-crypto-tlscredsx509.c.o
> In file included from ../../../tests/test-crypto-tlscredsx509.c:23:
> ../../../tests/crypto-tls-x509-helpers.h:128:14: warning: 'ASN1_ARRAY_TYPE'
> macro is deprecated, use 'asn1_static_node' instead. [-W#pragma-messages]
> extern const ASN1_ARRAY_TYPE pkix_asn1_tab[];
>              ^
> /opt/homebrew/Cellar/libtasn1/4.16.0/include/libtasn1.h:582:25: note:
> expanded from macro 'ASN1_ARRAY_TYPE'
> #define ASN1_ARRAY_TYPE _Pragma ("GCC warning \"'ASN1_ARRAY_TYPE' macro is
> deprecated, use 'asn1_static_node' instead.\"") asn1_static_node
>                         ^
> <scratch space>:18:6: note: expanded from here

This is really odd.

I've got the 4.16.0 tar.gz for libtasn1 and it does not contain any
such _Pragma / deprecation warnings.

The libtasn1  git repo *does* contain these pragmas, but only in the
dev tree for the unreleased 4.17.0 version.

The homebrew-core.git repo recipe for libtasn1 claims to be using
4.16.0 release

  https://github.com/Homebrew/homebrew-core/blob/master/Formula/libtasn1.rb

and those tarballs match what i have.

None the less it looks like your 4.16.0 installed version is in fact
a  git snapshot. Damned if I understand what homebrew is doing.

None the less, given that these deprecations are in libtasn1 git upstream,
we're going to have to deal with them.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|