Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user

[Paolo Bonzini]

On 16/02/21 11:52, Claudio Fontana wrote:
> I noticed also a call to cpu_load_efer() in gdbstub.c,
>
>          case IDX_CTL_EFER_REG:
>              if (env->hflags & HF_CS64_MASK) {
>                  cpu_load_efer(env, ldq_p(mem_buf));
>                  return 8;
>              }
>              cpu_load_efer(env, ldl_p(mem_buf));
>              return 4;
>
>          }
>
> Should this somehow restricted for user-mode, as it has the potential to set 
> HF_SVME ?

Yeah, it should.  Likewise for CR0/CR2/CR3/TPR.  Nice catch!

Paolo