Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase

From:	Richard Henderson
Subject:	Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public
Date:	Tue, 23 Feb 2021 17:38:28 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote:
> +#else /* !defined(TARGET_MIPS64) */
> +void mxu_translate_init(void)
> +{
> +    g_assert_not_reached();
> +}

This is suspect, see next patch.
The rest of it seems ok.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 03/10] target/mips: Remove unused CPUMIPSState* from MXU functions, (continued)
- [PATCH v3 04/10] target/mips: Pass instruction opcode to decode_opc_mxu(), Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 04/10] target/mips: Pass instruction opcode to decode_opc_mxu(), Richard Henderson, 2021/02/23
- [PATCH v3 05/10] target/mips: Extract decode_ase_mxu() from decode_opc_mxu(), Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 05/10] target/mips: Extract decode_ase_mxu() from decode_opc_mxu(), Richard Henderson, 2021/02/23
- [PATCH v3 06/10] target/mips: Use OPC_MUL instead of OPC__MXU_MUL, Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 06/10] target/mips: Use OPC_MUL instead of OPC__MXU_MUL, Richard Henderson, 2021/02/23
- [PATCH v3 07/10] target/mips: Introduce mxu_translate_init() helper, Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 07/10] target/mips: Introduce mxu_translate_init() helper, Richard Henderson, 2021/02/23
- [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public, Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public, Richard Henderson <=
- [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code, Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code, Richard Henderson, 2021/02/23
- [PATCH v3 10/10] target/mips: Extract MXU code to new mxu_translate.c file, Philippe Mathieu-Daudé, 2021/02/22
  - Re: [PATCH v3 10/10] target/mips: Extract MXU code to new mxu_translate.c file, Richard Henderson, 2021/02/23

Prev by Date: Re: [PATCH v3 07/10] target/mips: Introduce mxu_translate_init() helper
Next by Date: Re: [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code
Previous by thread: [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public
Next by thread: [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code
Index(es):
- Date
- Thread