Re: [PATCH 18/26] target/mips: Move Special opcodes to tcg/sysemu/special_helper.c

[Richard Henderson]

On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote:
> Move the Special opcodes helpers to tcg/sysemu/special_helper.c.
>
> Since mips_io_recompile_replay_branch() is set as
> CPUClass::io_recompile_replay_branch handler in cpu.c,
> we need to declare its prototype in "tcg-internal.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> -static void set_pc(CPUMIPSState *env, target_ulong error_pc)
> -{
> -    env->active_tc.PC = error_pc & ~(target_ulong)1;
> -    if (error_pc & 1) {
> -        env->hflags |= MIPS_HFLAG_M16;
> -    } else {
> -        env->hflags &= ~(MIPS_HFLAG_M16);
> -    }
> -}

I'll note that this is identical to mips_cpu_set_pc, bar CPUState vs 
CPUMIPSState.


r~