Re: [PATCH 20/26] target/mips: Move TLB management helpers to tcg/sysemu/tlb_helper.c

[Richard Henderson]

On 4/18/21 9:31 AM, Philippe Mathieu-Daudé wrote:
> Move TLB management helpers to tcg/sysemu/tlb_helper.c.
>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
> 4 checkpatch errors:
>
>    ERROR: space prohibited after that '&' (ctx:WxW)
>    #414: FILE: target/mips/tcg/sysemu/tlb_helper.c:71:
>    +    tlb->XI0 = (env->CP0_EntryLo0 >> CP0EnLo_XI) & 1;
>                                                      ^
>
>    ERROR: space prohibited after that '&' (ctx:WxW)
>    #415: FILE: target/mips/tcg/sysemu/tlb_helper.c:72:
>    +    tlb->RI0 = (env->CP0_EntryLo0 >> CP0EnLo_RI) & 1;
>                                                      ^
>
>    ERROR: space prohibited after that '&' (ctx:WxW)
>    #420: FILE: target/mips/tcg/sysemu/tlb_helper.c:77:
>    +    tlb->XI1 = (env->CP0_EntryLo1 >> CP0EnLo_XI) & 1;
>                                                      ^
>
>    ERROR: space prohibited after that '&' (ctx:WxW)
>    #421: FILE: target/mips/tcg/sysemu/tlb_helper.c:78:
>    +    tlb->RI1 = (env->CP0_EntryLo1 >> CP0EnLo_RI) & 1;
>                                                      ^

Wow, that's amazingly bogus.  I'm amazed that no one has re-written checkpatch 
in e.g. sparse...

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~