[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 6/7] virtiofsd/passthrough_ll.c: Changed local allocations to
|
From: |
Mahmoud Mandour |
|
Subject: |
[PATCH v2 6/7] virtiofsd/passthrough_ll.c: Changed local allocations to GLib functions |
|
Date: |
Tue, 20 Apr 2021 17:46:41 +0200 |
Changed the allocations of some local variables to GLib's allocation
functions, such as g_try_malloc0(), and annotated those variables
as g_autofree. Subsequently, I was able to remove the calls to free().
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index b9260c26d4..886498e8c3 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -1653,7 +1653,7 @@ static void lo_do_readdir(fuse_req_t req, fuse_ino_t ino,
size_t size,
struct lo_data *lo = lo_data(req);
struct lo_dirp *d = NULL;
struct lo_inode *dinode;
- char *buf = NULL;
+ g_autofree char *buf = NULL;
char *p;
size_t rem = size;
int err = EBADF;
@@ -1669,7 +1669,7 @@ static void lo_do_readdir(fuse_req_t req, fuse_ino_t ino,
size_t size,
}
err = ENOMEM;
- buf = calloc(1, size);
+ buf = g_try_malloc0(size);
if (!buf) {
goto error;
}
@@ -1755,7 +1755,6 @@ error:
} else {
fuse_reply_buf(req, buf, size - rem);
}
- free(buf);
}
static void lo_readdir(fuse_req_t req, fuse_ino_t ino, size_t size,
@@ -2727,7 +2726,7 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino,
const char *in_name,
size_t size)
{
struct lo_data *lo = lo_data(req);
- char *value = NULL;
+ g_autofree char *value = NULL;
char procname[64];
const char *name;
char *mapped_name;
@@ -2768,7 +2767,7 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino,
const char *in_name,
ino, name, size);
if (size) {
- value = malloc(size);
+ value = g_try_malloc(size);
if (!value) {
goto out_err;
}
@@ -2807,8 +2806,6 @@ static void lo_getxattr(fuse_req_t req, fuse_ino_t ino,
const char *in_name,
fuse_reply_xattr(req, ret);
}
out_free:
- free(value);
-
if (fd >= 0) {
close(fd);
}
@@ -2827,7 +2824,7 @@ out:
static void lo_listxattr(fuse_req_t req, fuse_ino_t ino, size_t size)
{
struct lo_data *lo = lo_data(req);
- char *value = NULL;
+ g_autofree char *value = NULL;
char procname[64];
struct lo_inode *inode;
ssize_t ret;
@@ -2849,7 +2846,7 @@ static void lo_listxattr(fuse_req_t req, fuse_ino_t ino,
size_t size)
size);
if (size) {
- value = malloc(size);
+ value = g_try_malloc(size);
if (!value) {
goto out_err;
}
@@ -2934,8 +2931,6 @@ static void lo_listxattr(fuse_req_t req, fuse_ino_t ino,
size_t size)
fuse_reply_xattr(req, ret);
}
out_free:
- free(value);
-
if (fd >= 0) {
close(fd);
}
--
2.25.1
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, (continued)
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Mahmoud Mandour, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Dr. David Alan Gilbert, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Mahmoud Mandour, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Dr. David Alan Gilbert, 2021/04/27
- [PATCH v3 2/7] virtiofsd: Changed allocations of iovec to GLib's functions, Mahmoud Mandour, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Mahmoud Mandour, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Dr. David Alan Gilbert, 2021/04/27
- Re: [PATCH v2 2/7] virtiofds: Changed allocations of iovec to GLib's functions, Daniel P . Berrangé, 2021/04/27
[PATCH v2 3/7] virtiofsd: Changed allocations of fuse_session to GLib's functions, Mahmoud Mandour, 2021/04/20
[PATCH v2 4/7] virtiofsd: Changed allocation of lo_map_elems to GLib's functions, Mahmoud Mandour, 2021/04/20
[PATCH v2 6/7] virtiofsd/passthrough_ll.c: Changed local allocations to GLib functions,
Mahmoud Mandour <=
[PATCH v2 7/7] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib, Mahmoud Mandour, 2021/04/20
[PATCH v2 5/7] virtiofsd: Changed allocations of fv_VuDev & its internals to GLib functions, Mahmoud Mandour, 2021/04/20