Re: [PATCH 07/13] target/arm: Make functions used by translate-vfp global

[Richard Henderson]

On 4/13/21 9:07 AM, Peter Maydell wrote:
> +static inline void gen_set_condexec(DisasContext *s)
> +{
> +    if (s->condexec_mask) {
> +        uint32_t val = (s->condexec_cond << 4) | (s->condexec_mask >> 1);
> +        TCGv_i32 tmp = tcg_temp_new_i32();
> +        tcg_gen_movi_i32(tmp, val);
> +        store_cpu_field(tmp, condexec_bits);
> +    }
> +}
> +
> +static inline void gen_set_cpsr(TCGv_i32 var, uint32_t mask)
> +{
> +    TCGv_i32 tmp_mask = tcg_const_i32(mask);
> +    gen_helper_cpsr_write(cpu_env, var, tmp_mask);
> +    tcg_temp_free_i32(tmp_mask);
> +}

So.. these were marked inline originally, but I don't see why they should be. 
I think you should put declarations here.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~