Re: [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler

From:	Gerd Hoffmann
Subject:	Re: [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler
Date:	Fri, 30 Apr 2021 12:02:23 +0200

  Hi,

> +        } else if (ctrl.code == VIRTIO_SND_R_JACK_INFO) {
> +            virtio_snd_log("VIRTIO_SND_R_JACK_INFO");

For that kind of tracing / debug logging it is useful to have
enum -> string mapping helper function(s).

take care,
  Gerd

[Prev in Thread]

Current Thread

[Next in Thread]

[RFC PATCH 04/27] virtio-snd: Add chmap control structures, (continued)
- [RFC PATCH 04/27] virtio-snd: Add chmap control structures, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 03/27] virtio-snd: Add PCM control structures, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 05/27] virtio-snd: Add device implementation structures, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 06/27] virtio-snd: Add PCI wrapper code for VirtIOSound, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 07/27] virtio-snd: Add properties for class init, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 08/27] virtio-snd: Add code for get config function, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 09/27] virtio-snd: Add code for set config function, Shreyansh Chouhan, 2021/04/29
  - Re: [RFC PATCH 09/27] virtio-snd: Add code for set config function, Gerd Hoffmann, 2021/04/30
- [RFC PATCH 10/27] virtio-snd: Add code for the realize function, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler, Shreyansh Chouhan, 2021/04/29
  - Re: [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler, Gerd Hoffmann <=
- [RFC PATCH 11/27] virtio-snd: Add macros for logging, Shreyansh Chouhan, 2021/04/29
  - Re: [RFC PATCH 11/27] virtio-snd: Add macros for logging, Gerd Hoffmann, 2021/04/30
- [RFC PATCH 13/27] virtio-snd: Add VIRTIO_SND_R_JACK_INFO handler, Shreyansh Chouhan, 2021/04/29
  - Re: [RFC PATCH 13/27] virtio-snd: Add VIRTIO_SND_R_JACK_INFO handler, Gerd Hoffmann, 2021/04/30
- [RFC PATCH 15/27] virtio-snd: Add VIRTIO_SND_R_PCM_INFO handler, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 14/27] virtio-snd: Add stub for VIRTIO_SND_R_JACK_REMAP handler, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 18/27] virtio-snd: Add default configs to realize fn, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 16/27] virtio-snd: Add VIRITO_SND_R_PCM_SET_PARAMS handle, Shreyansh Chouhan, 2021/04/29
- [RFC PATCH 21/27] virtio-snd: Add VIRTIO_SND_R_PCM_STOP handler, Shreyansh Chouhan, 2021/04/29
  - Re: [RFC PATCH 21/27] virtio-snd: Add VIRTIO_SND_R_PCM_STOP handler, Gerd Hoffmann, 2021/04/30

Prev by Date: Re: [RFC PATCH 11/27] virtio-snd: Add macros for logging
Next by Date: Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed
Previous by thread: [RFC PATCH 12/27] virtio-snd: Add control virtqueue handler
Next by thread: [RFC PATCH 11/27] virtio-snd: Add macros for logging
Index(es):
- Date
- Thread