[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables
From: |
Taylor Simpson |
Subject: |
[PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables |
Date: |
Fri, 18 Jun 2021 14:06:42 -0500 |
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-5-git-send-email-tsimpson@quicinc.com>
---
target/hexagon/genptr.c | 6 ------
target/hexagon/translate.c | 11 ++---------
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index bd18cb1..5dbabe0 100644
--- a/target/hexagon/genptr.c
+++ b/target/hexagon/genptr.c
@@ -121,10 +121,7 @@ static void gen_log_reg_write_pair(int rnum, TCGv_i64 val)
static inline void gen_log_pred_write(DisasContext *ctx, int pnum, TCGv val)
{
- TCGv zero = tcg_const_tl(0);
TCGv base_val = tcg_temp_new();
- TCGv and_val = tcg_temp_new();
- TCGv pred_written = tcg_temp_new();
tcg_gen_andi_tl(base_val, val, 0xff);
@@ -143,10 +140,7 @@ static inline void gen_log_pred_write(DisasContext *ctx,
int pnum, TCGv val)
}
tcg_gen_ori_tl(hex_pred_written, hex_pred_written, 1 << pnum);
- tcg_temp_free(zero);
tcg_temp_free(base_val);
- tcg_temp_free(and_val);
- tcg_temp_free(pred_written);
}
static inline void gen_read_p3_0(TCGv control_reg)
diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c
index 9a37644..b23d36a 100644
--- a/target/hexagon/translate.c
+++ b/target/hexagon/translate.c
@@ -273,7 +273,6 @@ static void gen_reg_writes(DisasContext *ctx)
static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
{
- TCGv zero, control_reg, pval;
int i;
/* Early exit if the log is empty */
@@ -281,10 +280,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
return;
}
- zero = tcg_const_tl(0);
- control_reg = tcg_temp_new();
- pval = tcg_temp_new();
-
/*
* Only endloop instructions will conditionally
* write a predicate. If there are no endloop
@@ -292,6 +287,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
* write of the predicates.
*/
if (pkt->pkt_has_endloop) {
+ TCGv zero = tcg_const_tl(0);
TCGv pred_written = tcg_temp_new();
for (i = 0; i < ctx->preg_log_idx; i++) {
int pred_num = ctx->preg_log[i];
@@ -302,6 +298,7 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
hex_new_pred_value[pred_num],
hex_pred[pred_num]);
}
+ tcg_temp_free(zero);
tcg_temp_free(pred_written);
} else {
for (i = 0; i < ctx->preg_log_idx; i++) {
@@ -314,10 +311,6 @@ static void gen_pred_writes(DisasContext *ctx, Packet *pkt)
}
}
}
-
- tcg_temp_free(zero);
- tcg_temp_free(control_reg);
- tcg_temp_free(pval);
}
static void gen_check_store_width(DisasContext *ctx, int slot_num)
--
2.7.4
- [PULL 0/4] Hexagon (target/hexagon) bug fixes, Taylor Simpson, 2021/06/18
- [PULL 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions, Taylor Simpson, 2021/06/18
- [PULL 2/4] Hexagon (target/hexagon) fix l2fetch instructions, Taylor Simpson, 2021/06/18
- [PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables,
Taylor Simpson <=
- [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW*, Taylor Simpson, 2021/06/18
- RE: [PULL 0/4] Hexagon (target/hexagon) bug fixes, Taylor Simpson, 2021/06/23
- Re: [PULL 0/4] Hexagon (target/hexagon) bug fixes, Peter Maydell, 2021/06/29
- Re: [PULL 0/4] Hexagon (target/hexagon) bug fixes, Peter Maydell, 2021/06/29