Re: [PATCH] hw/mips/jazz: Map the UART devices unconditionally

[Philippe Mathieu-Daudé]

On 6/29/21 7:37 AM, Philippe Mathieu-Daudé wrote:
> When using the Magnum ARC firmware we can see accesses to the
> UART1 beeing rejected, because the device is not mapped:
> 
>   $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007001, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007002, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007003, size 1, region '(null)', reason: rejected
>   Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejected
> 
> Since both UARTs are present (soldered on the board) regardless there
> are character devices connected, map them unconditionally.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/mips/jazz.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)

Patch queued to mips-next (with Peter's corrections applied).