Re: [PATCH v2 5/5] configure: allow the selection of alternate config in the build

[Richard Henderson]

On 7/7/21 6:17 AM, Alex Bennée wrote:
> While the default config works well enough it does end up enabling a
> lot of stuff. For more minimal builds we can select a different list
> of devices and let Kconfig work out what we want. For example:
>
>    ../../configure --without-default-features \
>      --target-list=arm-softmmu,aarch64-softmmu \
>      --with-devices-aarch64=minimal
>
> will override the aarch64-softmmu default set of devices with a more
> minimal set of devices that just enables the virt and sbsa-ref models.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Philippe Mathieu-Daudé<philmd@redhat.com>
> Cc: Paolo Bonzini<pbonzini@redhat.com>
> Message-Id:<20210621152120.4465-6-alex.bennee@linaro.org>

I guess I can just follow the shell scripting.  It's a shame we can't just put together 
the properties section contents while we're parsing the command-line, and instead have to 
break it up into N variables.

> +  # unroll any custom device configs
> +  if test -n "$device_archs"; then
> +      for a in $device_archs; do
> +          eval "c=\$devices_${a}"
> +          echo "${a}-softmmu = '$c'" >> $cross
> +      done
> +  fi

Do you really need the IF around the FOR?  Shouldn't the loop iterate zero times if 
$device_archs is empty?

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~