Re: [PATCH v2 31/39] tcg/plugins: enable by default for TCG builds

[Richard Henderson]

On 7/8/21 12:09 PM, Alex Bennée wrote:
> -The QEMU binary needs to be compiled for plugin support::
> +Any QEMU binary with TCG support has plugins enabled by default.

Not true for windows.


> +##########################################
> +# plugin linker support probe
> +
> +if test "$plugins" != "no"; then
> +
> +    #########################################
> +    # See if --dynamic-list is supported by the linker
> +
> +    ld_dynamic_list="no"
> +    if test "$static" = "no" ; then
...
> +    if test "$ld_dynamic_list" = "no" &&
> +       test "$ld_exported_symbols_list" = "no" ; then
> +        if test "$plugins" = "yes"; then
> +            error_exit \
> +                "Plugin support requires dynamic linking and specifying a set of 
> symbols " \
> +                "that are exported to plugins. Unfortunately your linker doesn't 
> " \
> +                "support the flag (--dynamic-list or -exported_symbols_list) used 
> " \
> +                "for this purpose. You can't build with --static."
> +        else
> +            plugins="no"
> +        fi

I think it would be clearer for the code and the error message to detect static && plugins 
early, so that you don't confuse the --static message with the --dynamic-list message.


r~