[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test
|
From: |
Igor Mammedov |
|
Subject: |
Re: [PATCH v8 9/9] qtest/hyperv: Introduce a simple hyper-v test |
|
Date: |
Fri, 9 Jul 2021 10:22:42 +0200 |
On Thu, 8 Jul 2021 17:02:22 -0400
Eduardo Habkost <ehabkost@redhat.com> wrote:
> On Tue, Jun 08, 2021 at 02:08:17PM +0200, Vitaly Kuznetsov wrote:
> > For the beginning, just test 'hv-passthrough' and a couple of custom
> > Hyper-V enlightenments configurations through QMP. Later, it would
> > be great to complement this by checking CPUID values from within the
> > guest.
> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> [...]
> > +static bool kvm_has_sys_hyperv_cpuid(void)
> > +{
> > + int fd = open("/dev/kvm", O_RDWR);
> > + int ret;
> > +
> > + g_assert(fd > 0);
>
> This crashes when /dev/kvm doesn't exist. See:
> https://gitlab.com/ehabkost/qemu/-/jobs/1404084459
maybe reuse qtest_has_accel()
https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg06864.html
instead of op encoding it.
> I'm removing it from the queue.
>