Re: [PATCH v1 3/5] hw/intc: ibex_plic: Convert the PLIC to use RISC-V CPU GPIO lines

[Richard Henderson]

On 7/8/21 8:31 PM, Alistair Francis wrote:
> +        if (ibex_plic_irqs_pending(s, 0)) {
> +            qemu_irq_raise(s->external_irqs[i]);
> +        } else {
> +            qemu_irq_lower(s->external_irqs[i]);
>           }
> -
> -        level = ibex_plic_irqs_pending(s, 0);
> -
> -        riscv_cpu_update_mip(RISCV_CPU(cpu), MIP_MEIP, BOOL_TO_MASK(level));

Use qemu_irq_set.  Whether you retain the level variable is up to you.

With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~