[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/11] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write
|
From: |
Richard Henderson |
|
Subject: |
[PATCH 07/11] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write |
|
Date: |
Mon, 12 Jul 2021 14:55:31 -0700 |
>From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
[-Werror,-Wunused-but-set-variable]
It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.
Cc: qemu-ppc@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/pci-host/pnv_phb4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c660a..5c375a9f28 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
v &= 0xffffffffffff0000ull;
v |= 0x000000000000cfffull & val;
}
- *tptr = val;
+ *tptr = v;
break;
}
case IODA3_TBL_MBT:
--
2.25.1
- [PATCH 01/11] nbd/server: Remove unused variable, (continued)
[PATCH 04/11] net/checksum: Remove unused variable in net_checksum_add_iov, Richard Henderson, 2021/07/12
[PATCH 03/11] util/selfmap: Discard mapping on error, Richard Henderson, 2021/07/12
[PATCH 02/11] accel/tcg: Remove unused variable in cpu_exec, Richard Henderson, 2021/07/12
[PATCH 07/11] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write,
Richard Henderson <=
[PATCH 05/11] hw/audio/adlib: Remove unused variable in adlib_callback, Richard Henderson, 2021/07/12
[PATCH 06/11] hw/ppc/spapr_events: Remove unused variable from check_exception, Richard Henderson, 2021/07/12
[PATCH 08/11] linux-user/syscall: Remove unused variable from execve, Richard Henderson, 2021/07/12
[PATCH 11/11] tcg/ppc: Ensure _CALL_SYSV is set for 32-bit ELF, Richard Henderson, 2021/07/12
[PATCH 09/11] tests/unit: Remove unused variable from test_io, Richard Henderson, 2021/07/12