Re: [PATCH 10/13] tests/plugins/insn: made arg inline not positional and

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/13] tests/plugins/insn: made arg inline not positional and

From:	Alex Bennée
Subject:	Re: [PATCH 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool
Date:	Mon, 19 Jul 2021 15:59:08 +0100
User-agent:	mu4e 1.5.14; emacs 28.0.50

Mahmoud Mandour <ma.mandourr@gmail.com> writes:

> Made argument "inline" not positional, this has two benefits. First is
> that we adhere to how QEMU passes args generally, by taking the last
> value of an argument and drop the others. And the second is that this
> sets up a framework for potentially adding new args easily.
>
> Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 02/13] plugins/api: added a boolean parsing plugin api, (continued)
- [PATCH 07/13] plugins/howvec: Adapting to the new argument passing scheme., Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 07/13] plugins/howvec: Adapting to the new argument passing scheme., Alex Bennée, 2021/07/19
- [PATCH 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Alex Bennée, 2021/07/19
- [PATCH 05/13] plugins/lockstep: make socket path not positional & parse bool arg, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 05/13] plugins/lockstep: make socket path not positional & parse bool arg, Alex Bennée, 2021/07/19
- [PATCH 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs, Alex Bennée, 2021/07/19
- [PATCH 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool, Alex Bennée <=
- [PATCH 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme, Alex Bennée, 2021/07/19
- [PATCH 11/13] tests/plugins/mem: introduce "track" arg and make args not positional, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 11/13] tests/plugins/mem: introduce "track" arg and make args not positional, Alex Bennée, 2021/07/19
- [PATCH 13/13] docs/deprecated: deprecate passing plugin args through `arg=`, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 13/13] docs/deprecated: deprecate passing plugin args through `arg=`, Peter Krempa, 2021/07/19
- [PATCH 09/13] tests/plugins/bb: adapt to the new arg passing scheme, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 09/13] tests/plugins/bb: adapt to the new arg passing scheme, Alex Bennée, 2021/07/19
- [PATCH 04/13] plugins/hotblocks: Added correct boolean argument parsing, Mahmoud Mandour, 2021/07/17
  - Re: [PATCH 04/13] plugins/hotblocks: Added correct boolean argument parsing, Alex Bennée, 2021/07/19

Prev by Date: Re: [PATCH 09/13] tests/plugins/bb: adapt to the new arg passing scheme
Next by Date: Re: [PATCH v5 02/10] ACPI ERST: specification for ERST support
Previous by thread: [PATCH 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool
Next by thread: [PATCH 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme
Index(es):
- Date
- Thread