Re: [PATCH for-6.2 32/34] target/arm: Implement MVE scatter-gather insns

[Richard Henderson]

On 7/13/21 3:37 AM, Peter Maydell wrote:
> +static bool do_ldst_sg(DisasContext *s, arg_vldst_sg *a, MVEGenLdStSGFn fn)
> +{
> +    TCGv_i32 addr;
> +    TCGv_ptr qd, qm;
> +
> +    if (!dc_isar_feature(aa32_mve, s) ||
> +        !mve_check_qreg_bank(s, a->qd | a->qm) ||
> +        !fn || a->rn == 15) {
> +        /* Rn case is UNPREDICTABLE */
> +        return false;
> +    }

No Qd != Qm check for loads?  Given that we know in advance that it simply won't work for 
VLDRD, it would be nice to diagnose the error.

> +static bool trans_VLDR_S_sg(DisasContext *s, arg_vldst_sg *a)
> +{
> +    static MVEGenLdStSGFn * const fns[2][4][4] = { {
> +            { NULL, F(vldrb_sg_sh), F(vldrb_sg_sw), NULL },
> +            { NULL, NULL,           F(vldrh_sg_sw), NULL },
> +            { NULL, NULL,           NULL,           NULL },
> +            { NULL, NULL,           NULL,           NULL }
> +        }, {
> +            { NULL, NULL,              NULL,              NULL },
> +            { NULL, NULL,              F(vldrh_sg_os_sw), NULL },
> +            { NULL, NULL,              NULL,              NULL },
> +            { NULL, NULL,              NULL,              NULL }
> +        }
> +    };

A little bit unfortunate with table density here, but whatever.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~