[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 13/43] target/sparc: Remove DEBUG_UNALIGNED
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-6.2 13/43] target/sparc: Remove DEBUG_UNALIGNED |
|
Date: |
Thu, 29 Jul 2021 08:16:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/29/21 2:46 AM, Richard Henderson wrote:
> The printf should have been qemu_log_mask, the parameters
> themselves no longer compile, and because this is placed
> before unwinding the PC is actively wrong.
>
> We get better (and correct) logging on the other side of
> raising the exception, in sparc_cpu_do_interrupt.
>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/sparc/ldst_helper.c | 9 ---------
> 1 file changed, 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH for-6.2 16/43] target/xtensa: Implement do_unaligned_access for user-only, (continued)
- [PATCH for-6.2 12/43] target/sh4: Implement do_unaligned_access for user-only, Richard Henderson, 2021/07/28
- [PATCH for-6.2 17/43] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/07/28
- [PATCH for-6.2 18/43] accel/tcg: Drop signness in tracing in cputlb.c, Richard Henderson, 2021/07/28
- [PATCH for-6.2 11/43] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/07/28
- [PATCH for-6.2 13/43] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/07/28
- Re: [PATCH for-6.2 13/43] target/sparc: Remove DEBUG_UNALIGNED,
Philippe Mathieu-Daudé <=
- [PATCH for-6.2 14/43] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/07/28
- [PATCH for-6.2 19/43] tcg: Expand MO_SIZE to 3 bits, Richard Henderson, 2021/07/28
- [PATCH for-6.2 15/43] target/sparc: Implement do_unaligned_access for user-only, Richard Henderson, 2021/07/28
- [PATCH for-6.2 21/43] tcg: Split out MemOpIdx to exec/memopidx.h, Richard Henderson, 2021/07/28
- [PATCH for-6.2 24/43] accel/tcg: Pass MemOpIdx to atomic_trace_*_post, Richard Henderson, 2021/07/28