qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 06/11] qapidoc: introduce QAPISchemaIfCond.docgen()


From: Marc-André Lureau
Subject: Re: [PATCH v6 06/11] qapidoc: introduce QAPISchemaIfCond.docgen()
Date: Wed, 4 Aug 2021 12:23:06 +0400

Hi

On Mon, Aug 2, 2021 at 7:47 PM Markus Armbruster <armbru@redhat.com> wrote:
marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Instead of building the condition documentation from a list of string,
> use the result generated from QAPISchemaIfCond.docgen().
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

I suspect this changes the generated documentation, similar to how the
previous patch changes generated code.  True?  If yes, can you show us
how?


This changes the generated documentation from:
- COND1, COND2... (where COND1, COND2 are Literal nodes, and ',' is Text)
to:
- COND1 and COND2 (the whole string as a Literal node)

This will allow us to generate more complex conditions in the following patches, such as "(COND1 and COND2) or COND3".

Adding back the formatting is left to the wish list.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]