Re: [RFC PATCH v4 1/4] Add options to config/meson files for custom CSR

[Bin Meng]

On Fri, Aug 6, 2021 at 8:58 PM Jessica Clarke <jrtc27@jrtc27.com> wrote:
>
> > On Fri, Aug 6, 2021 at 10:39 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> > >
> > > On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai
> > > <ruinland@andestech.com> wrote:
> > > >
> > > > From: Ruinland ChuanTzu Tsai <ruinland@andestech.com>
> > > >
> > > > Adding option `riscv_custom` to configure script, meson.build and
> > > > meson_options.txt so as to toggle custom CSR and will-be-upstreamed 
> > > > custom
> > > > instructions handling logic.
> > > >
> > > > Signed-off-by: Dylan Jhong <dylan@andestech.com>
> > > > ---
> > > >  configure         | 6 ++++++
> > > >  meson.build       | 2 ++
> > > >  meson_options.txt | 2 ++
> > > >  3 files changed, 10 insertions(+)
> > > >
> > >
> > > This sounds like unnecessary to bring such a config option to the meson 
> > > level.
> > >
> > > I believe a Kconfig option should just be fine.
> >
> > +Alistair
>
> I don’t see why this is even a config option. If you request a vendor’s
> CPU you should get any custom CSRs defined for that vendor’s CPU. If
> you don’t you don’t. This should be purely a run-time thing, no?

In a generic use case where we build all RISC-V machines into one
qemu-system-riscv{32,64} executable this makes no difference. The
Kconfig option will be turned on if any one of the machines requires
it. It only gets benefits when we build a QEMU executable on a
per-machine basis.

Regards,
Bin