qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 08/33] block/backup: set copy_range and compress after fil


From: Hanna Reitz
Subject: Re: [PATCH v7 08/33] block/backup: set copy_range and compress after filter insertion
Date: Tue, 10 Aug 2021 17:07:45 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote:
We are going to publish copy-before-write filter, so it would be
initialized through options. Still we don't want to publish compress
and copy-range options, as

1. Modern way to enable compression is to use compress filter.

2. For copy-range it's unclean how to make proper interface:
  - it's has experimental prefix for backup job anyway
  - the whole BackupPerf structure doesn't make sense for the filter
  So, let's just add copy-range possibility to the filter later if
  needed.

Still, we are going to continue support for compression and
experimental copy-range in backup job. So, set these options after
filter creation.

Note, that we can drop "compress" argument of bdrv_cbw_append() now, as
well as "perf". The only reason not doing so is that now, when I
prepare this patch the big series around it is already reviewed and I
want to avoid extra rebase conflicts to simplify review of the
following version.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
  block/copy-before-write.h | 1 -
  block/backup.c            | 3 ++-
  block/copy-before-write.c | 4 +---
  3 files changed, 3 insertions(+), 5 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]