Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers

From:	Richard Henderson
Subject:	Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers
Date:	Wed, 18 Aug 2021 16:01:19 -1000
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/18/21 12:58 AM, Bin Meng wrote:

+    TCGv temp[4];


Why is 4? Is it enough? Perhaps a comment here is needed here?


It's a round number that will cover three operands plus an extra for address 
computation.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 01/21] target/riscv: Use tcg_constant_*, (continued)
- [PATCH v2 02/21] target/riscv: Clean up division helpers, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 02/21] target/riscv: Clean up division helpers, Bin Meng, 2021/08/18
- [PATCH v2 03/21] target/riscv: Add DisasContext to gen_get_gpr, gen_set_gpr, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 03/21] target/riscv: Add DisasContext to gen_get_gpr, gen_set_gpr, Philippe Mathieu-Daudé, 2021/08/17
  - Re: [PATCH v2 03/21] target/riscv: Add DisasContext to gen_get_gpr, gen_set_gpr, Bin Meng, 2021/08/18
  - Re: [PATCH v2 03/21] target/riscv: Add DisasContext to gen_get_gpr, gen_set_gpr, Alistair Francis, 2021/08/19
- [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers, Bin Meng, 2021/08/18
    - Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers, Richard Henderson, 2021/08/18
    - Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers, Richard Henderson <=
  - Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers, Alistair Francis, 2021/08/19
- [PATCH v2 05/21] target/riscv: Add DisasExtend to gen_arith*, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 05/21] target/riscv: Add DisasExtend to gen_arith*, Bin Meng, 2021/08/18
  - Re: [PATCH v2 05/21] target/riscv: Add DisasExtend to gen_arith*, Alistair Francis, 2021/08/19
- [PATCH v2 06/21] target/riscv: Remove gen_arith_div*, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 06/21] target/riscv: Remove gen_arith_div*, Bin Meng, 2021/08/18
  - Re: [PATCH v2 06/21] target/riscv: Remove gen_arith_div*, Alistair Francis, 2021/08/19
- [PATCH v2 07/21] target/riscv: Use gen_arith for mulh and mulhu, Richard Henderson, 2021/08/17
  - Re: [PATCH v2 07/21] target/riscv: Use gen_arith for mulh and mulhu, Bin Meng, 2021/08/18
  - Re: [PATCH v2 07/21] target/riscv: Use gen_arith for mulh and mulhu, Alistair Francis, 2021/08/19

Prev by Date: [PATCH v2] net/colo: check vnet_hdr_support flag when using virtio-net
Next by Date: Re: [PATCH v2 05/21] target/riscv: Add DisasExtend to gen_arith*
Previous by thread: Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers
Next by thread: Re: [PATCH v2 04/21] target/riscv: Introduce DisasExtend and new helpers
Index(es):
- Date
- Thread