Re: [PATCH v6 02/16] machine: Deprecate "parameter=0" SMP configurations

[Cornelia Huck]

On Thu, Aug 19 2021, Yanan Wang <wangyanan55@huawei.com> wrote:

> In the SMP configuration, we should either provide a topology
> parameter with a reasonable value (greater than zero) or just
> omit it and QEMU will compute the missing value.
>
> The users shouldn't provide a configuration with any parameter
> of it specified as zero (e.g. -smp 8,sockets=0) which could
> possibly cause unexpected results in the -smp parsing. So we
> deprecate this kind of configurations since 6.2 by adding the
> explicit sanity check.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
>  docs/about/deprecated.rst | 15 +++++++++++++++
>  hw/core/machine.c         | 14 ++++++++++++++
>  qapi/machine.json         |  2 +-
>  qemu-options.hx           | 12 +++++++-----
>  4 files changed, 37 insertions(+), 6 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>