Re: [PATCH for 6.2 40/49] bsd-user: Add target_arch_reg to describe a target's register set

[Warner Losh]

> On Aug 10, 2021, at 10:44 AM, Richard Henderson 
> <richard.henderson@linaro.org> wrote:
> 
> On 8/7/21 11:42 AM, Warner Losh wrote:
>> From: Warner Losh<imp@FreeBSD.org>
>> target_reg_t is the normal register. target_fpreg_t is the floating
>> point registers. target_copy_regs copies the registers out of CPU
>> context for things like core dumps.
>> Signed-off-by: Stacey Son<sson@FreeBSD.org>
>> Signed-off-by: Warner Losh<imp@bsdimp.com>
>> ---
>>  bsd-user/i386/target_arch_reg.h   | 82 +++++++++++++++++++++++++++
>>  bsd-user/x86_64/target_arch_reg.h | 92 +++++++++++++++++++++++++++++++
>>  2 files changed, 174 insertions(+)
>>  create mode 100644 bsd-user/i386/target_arch_reg.h
>>  create mode 100644 bsd-user/x86_64/target_arch_reg.h
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> While this mirrors what linux-user does, I've wondered if this wasn't just 
> pointless copying.  If a bit of code knows enough about a target to fill in 
> its core dump, why wouldn't it just copy the data straight from CPUArchState 
> instead of using these intermediaries?

I believe the forthcoming core dump code copies this opaque structure into the 
core dump….

However, this is an excellent todo item to see if there’s something that can be 
refined.

Warner

signature.asc
Description: Message signed with OpenPGP