Re: [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension

From:	Richard Henderson
Subject:	Re: [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension
Date:	Mon, 23 Aug 2021 11:29:48 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/23/21 11:11 AM, Philipp Tomsich wrote:

+    /* ... then shift the result 1 bit to the right. */
+    TCGv dst = tcg_temp_new();
+    gen_get_gpr(dst, a->rd);
+    tcg_gen_shri_tl(dst, dst, 1);
+    gen_set_gpr(a->rd, dst);
+    tcg_temp_free(dst);


Missed review changes from v3:

static void gen_clmulh(TCGv dst, TCGv src1, TCGv src2)
{
    gen_helper_clmulr(dst, src1, src2);
    tcg_gen_shri_tl(dst, dst, 1);
}


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 00/14] target/riscv: Update QEmu for Zb[abcs] 1.0.0, Philipp Tomsich, 2021/08/23
- [PATCH v4 01/14] target/riscv: Add x-zba, x-zbb, x-zbc and x-zbs properties, Philipp Tomsich, 2021/08/23
- [PATCH v4 04/14] target/riscv: Remove the W-form instructions from Zbs, Philipp Tomsich, 2021/08/23
- [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension, Philipp Tomsich, 2021/08/23
  - Re: [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension, Richard Henderson <=
- [PATCH v4 11/14] target/riscv: Add rev8 instruction, removing grev/grevi, Philipp Tomsich, 2021/08/23
- [PATCH v4 10/14] target/riscv: Add a REQUIRE_32BIT macro, Philipp Tomsich, 2021/08/23
- [PATCH v4 14/14] disas/riscv: Add Zb[abcs] instructions, Philipp Tomsich, 2021/08/23
- [PATCH v4 06/14] target/riscv: Reassign instructions to the Zbs-extension, Philipp Tomsich, 2021/08/23
- [PATCH v4 03/14] target/riscv: slli.uw is only a valid encoding if shamt first in 64 bits, Philipp Tomsich, 2021/08/23
- [PATCH v4 02/14] target/riscv: Reassign instructions to the Zba-extension, Philipp Tomsich, 2021/08/23
- [PATCH v4 05/14] target/riscv: Remove shift-one instructions (proposed Zbo in pre-0.93 draft-B), Philipp Tomsich, 2021/08/23
- [PATCH v4 09/14] target/riscv: Add orc.b instruction for Zbb, removing gorc/gorci, Philipp Tomsich, 2021/08/23
- [PATCH v4 08/14] target/riscv: Reassign instructions to the Zbb-extension, Philipp Tomsich, 2021/08/23
- [PATCH v4 13/14] target/riscv: Remove RVB (replaced by Zb[abcs], Philipp Tomsich, 2021/08/23

Prev by Date: [PATCH v4 12/14] target/riscv: Add zext.h instructions to Zbb, removing pack/packu/packh
Next by Date: Re: [PATCH v2 2/3] hw/usb/hcd-xhci-pci: Abort if setting link property failed
Previous by thread: [PATCH v4 07/14] target/riscv: Add instructions of the Zbc-extension
Next by thread: [PATCH v4 11/14] target/riscv: Add rev8 instruction, removing grev/grevi
Index(es):
- Date
- Thread