Re: [PATCH for-6.2 v3 04/12] job: Force-cancel jobs in a failed transaction

[Vladimir Sementsov-Ogievskiy]

06.08.2021 12:38, Max Reitz wrote:
> When a transaction is aborted, no result matters, and so all jobs within
> should be force-cancelled.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   job.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/job.c b/job.c
> index 3fe23bb77e..24e7c4fcb7 100644
> --- a/job.c
> +++ b/job.c
> @@ -766,7 +766,12 @@ static void job_completed_txn_abort(Job *job)
>           if (other_job != job) {
>               ctx = other_job->aio_context;
>               aio_context_acquire(ctx);
> -            job_cancel_async(other_job, false);
> +            /*
> +             * This is a transaction: If one job failed, no result will matter.
> +             * Therefore, pass force=true to terminate all other jobs as 
> quickly
> +             * as possible.
> +             */
> +            job_cancel_async(other_job, true);
>               aio_context_release(ctx);
>           }
>       }

Anyway, only backup jobs may be in a transaction, which doesn't distinguish 
force and soft cancelling. So, that doesn't change any logic.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir