[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 4/5] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 4/5] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all() |
Date: |
Thu, 2 Sep 2021 18:50:38 +0200 |
vring_get_region_caches() must be called with the RCU read lock
acquired. virtqueue_packed_drop_all() does not, and uses the
'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD()
macro.
Reported-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/virtio/virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 97f60017466..7d3bf9091ee 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1704,6 +1704,8 @@ static unsigned int virtqueue_packed_drop_all(VirtQueue
*vq)
VirtIODevice *vdev = vq->vdev;
VRingPackedDesc desc;
+ RCU_READ_LOCK_GUARD();
+
caches = vring_get_region_caches(vq);
if (!caches) {
return 0;
--
2.31.1
- [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 1/5] hw/virtio: Document virtio_queue_packed_empty_rcu is called within RCU, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 2/5] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock, Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 3/5] hw/virtio: Remove NULL check in virtio_free_region_cache(), Philippe Mathieu-Daudé, 2021/09/02
- [PATCH v2 4/5] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all(),
Philippe Mathieu-Daudé <=
- [PATCH v2 5/5] hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees, Philippe Mathieu-Daudé, 2021/09/02
- Re: [PATCH v2 0/5] hw/virtio: Minor housekeeping patches, Michael S. Tsirkin, 2021/09/05