[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 21/43] bsd-user: pull in target_arch_thread.h update targe
|
From: |
Kyle Evans |
|
Subject: |
Re: [PATCH v3 21/43] bsd-user: pull in target_arch_thread.h update target_arch_elf.h |
|
Date: |
Sun, 5 Sep 2021 14:03:34 -0500 |
On Thu, Sep 2, 2021 at 6:55 PM <imp@bsdimp.com> wrote:
>
> From: Warner Losh <imp@FreeBSD.org>
>
> Update target_arch_elf.h to remove thread_init. Move its contents to
> target_arch_thread.h and rename to target_thread_init(). Update
> elfload.c to call it. Create thread_os_thread.h to hold the os specific
> parts of the thread and threat manipulation routines. Currently, it just
s/threat/thread/
> includes target_arch_thread.h. target_arch_thread.h contains the at the
> moment unused target_thread_set_upcall which will be used in the future
> when creating actual thread (i386 has this stubbed, but other
> architectures in the bsd-user tree have real ones). FreeBSD doesn't do
> AT_HWCAP, so remove that code. Linux does, and this code came from there.
>
> These changes are all interrelated and could be brokend own, but seem to
s/brokend own/broken down/
> represent a reviewable changeset since most of the change is boiler
> plate.
>
> Signed-off-by: Stacey Son <sson@FreeBSD.org>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/elfload.c | 4 ++-
> bsd-user/freebsd/target_os_thread.h | 25 +++++++++++++
> bsd-user/i386/target_arch_elf.h | 52 ++--------------------------
> bsd-user/i386/target_arch_thread.h | 47 +++++++++++++++++++++++++
> bsd-user/netbsd/target_os_thread.h | 25 +++++++++++++
> bsd-user/openbsd/target_os_thread.h | 25 +++++++++++++
> bsd-user/x86_64/target_arch_elf.h | 38 ++------------------
> bsd-user/x86_64/target_arch_thread.h | 40 +++++++++++++++++++++
> 8 files changed, 171 insertions(+), 85 deletions(-)
> create mode 100644 bsd-user/freebsd/target_os_thread.h
> create mode 100644 bsd-user/i386/target_arch_thread.h
> create mode 100644 bsd-user/netbsd/target_os_thread.h
> create mode 100644 bsd-user/openbsd/target_os_thread.h
> create mode 100644 bsd-user/x86_64/target_arch_thread.h
>
Minor message nits, but otherwise:
Reviewed-by: Kyle Evans <kevans@FreeBSD.org>
- [PATCH v3 12/43] bsd-user: remove a.out support, (continued)
- [PATCH v3 12/43] bsd-user: remove a.out support, imp, 2021/09/02
- [PATCH v3 13/43] bsd-user: TARGET_NGROUPS unused in this file, remove, imp, 2021/09/02
- [PATCH v3 16/43] bsd-user: add host-os.h, imp, 2021/09/02
- [PATCH v3 25/43] bsd-user: Add system independent stack, data and text limiting, imp, 2021/09/02
- [PATCH v3 18/43] bsd-user: save the path to the qemu emulator, imp, 2021/09/02
- [PATCH v3 17/43] bsd-user: Include host-os.h from main, imp, 2021/09/02
- [PATCH v3 26/43] bsd-user: *BSD specific siginfo defintions, imp, 2021/09/02
- [PATCH v3 21/43] bsd-user: pull in target_arch_thread.h update target_arch_elf.h, imp, 2021/09/02
- Re: [PATCH v3 21/43] bsd-user: pull in target_arch_thread.h update target_arch_elf.h,
Kyle Evans <=
- [PATCH v3 30/43] bsd-user: elf cleanup, imp, 2021/09/02
- [PATCH v3 19/43] bsd-user: start to move target CPU functions to target_arch*, imp, 2021/09/02
- [PATCH v3 15/43] bsd-user: assume pthreads and support of __thread, imp, 2021/09/02
- [PATCH v3 23/43] bsd-user: define max args in terms of pages, imp, 2021/09/02
- [PATCH v3 22/43] bsd-user: Include more things in qemu.h, imp, 2021/09/02
- [PATCH v3 24/43] bsd-user: Create target specific vmparam.h, imp, 2021/09/02
- [PATCH v3 33/43] bsd-user: Make cpu_model and cpu_type visible to all of main.c, imp, 2021/09/02