[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] i386: Add sgx_get_info() interface
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 3/7] i386: Add sgx_get_info() interface |
|
Date: |
Wed, 8 Sep 2021 10:32:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/8/21 10:19 AM, Yang Zhong wrote:
> Add the sgx_get_info() interface for hmp and QMP usage, which
> will get the SGX info from this API.
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
> hw/i386/sgx.c | 21 +++++++++++++++++++++
> include/hw/i386/sgx.h | 11 +++++++++++
> target/i386/monitor.c | 32 ++++++++++++++++++++++++++++----
> 3 files changed, 60 insertions(+), 4 deletions(-)
> create mode 100644 include/hw/i386/sgx.h
> @@ -766,12 +767,35 @@ qmp_query_sev_attestation_report(const char *mnonce,
> Error **errp)
>
> SGXInfo *qmp_query_sgx(Error **errp)
> {
> - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
> void hmp_info_sgx(Monitor *mon, const QDict *qdict)
> {
> - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx");
> - return NULL;
What is the point of patches #1 & #2? Why not squash all here?
- [PATCH 0/7] The HMP/QMP interfaces in Qemu SGX, Yang Zhong, 2021/09/08
- [PATCH 2/7] hmp: Add 'info sgx' command, Yang Zhong, 2021/09/08
- [PATCH 3/7] i386: Add sgx_get_info() interface, Yang Zhong, 2021/09/08
- [PATCH 1/7] qmp: Add query-sgx command, Yang Zhong, 2021/09/08
- [PATCH 4/7] bitops: Support 32 and 64 bit mask macro, Yang Zhong, 2021/09/08
- [PATCH 5/7] qmp: Add the qmp_query_sgx_capabilities(), Yang Zhong, 2021/09/08