[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 5/7] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller
From: |
Richard Henderson |
Subject: |
[RFC PATCH 5/7] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller |
Date: |
Mon, 13 Sep 2021 15:05:50 -0700 |
Remove the comment about siglongjmp. We do use sigsetjmp
in the main cpu loop, but we do not save the signal mask
as most exits from the cpu loop do not require them.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/user-exec.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index 83351db719..ad6b4f6abf 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -46,17 +46,6 @@ __thread uintptr_t helper_retaddr;
//#define DEBUG_SIGNAL
-/* exit the current TB from a signal handler. The host registers are
- restored in a state compatible with the CPU emulator
- */
-static void QEMU_NORETURN cpu_exit_tb_from_sighandler(CPUState *cpu,
- sigset_t *old_set)
-{
- /* XXX: use siglongjmp ? */
- sigprocmask(SIG_SETMASK, old_set, NULL);
- cpu_loop_exit_noexc(cpu);
-}
-
/**
* adjust_signal_pc:
* @pc: raw pc from the host signal ucontext_t.
@@ -157,9 +146,9 @@ bool handle_sigsegv_accerr_write(CPUState *cpu, sigset_t
*old_set,
* currently executing TB was modified and must be exited
* immediately. Clear helper_retaddr for next execution.
*/
- cpu_exit_tb_from_sighandler(cpu, old_set);
+ sigprocmask(SIG_SETMASK, old_set, NULL);
+ cpu_loop_exit_noexc(cpu);
/* NORETURN */
-
default:
g_assert_not_reached();
}
--
2.25.1
- Re: [RFC PATCH 6/7] linux-user: Handle SIGSEGV/SIGBUS in host_to_target_siginfo_noswap, (continued)
- [RFC PATCH 2/7] accel/tcg: Split out adjust_signal_pc, Richard Henderson, 2021/09/13
- [RFC PATCH 3/7] accel/tcg: Split out handle_sigsegv_accerr_write, Richard Henderson, 2021/09/13
- [RFC PATCH 1/7] include/exec: Move cpu_signal_handler declaration, Richard Henderson, 2021/09/13
- [RFC PATCH 4/7] accel/tcg: Move clear_helper_retaddr to cpu loop, Richard Henderson, 2021/09/13
- [RFC PATCH 5/7] accel/tcg: Fold cpu_exit_tb_from_sighandler into caller,
Richard Henderson <=
- [RFC PATCH 7/7] linux-user: Reorg cpu_signal_handler, Richard Henderson, 2021/09/13
- Re: [RFC PATCH 0/7] linux-user: Streamline handling of SIGSEGV/SIGBUS, Richard Henderson, 2021/09/13