[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/10] linux-user: Drop unneeded includes from qemu.h
From: |
Laurent Vivier |
Subject: |
[PULL 09/10] linux-user: Drop unneeded includes from qemu.h |
Date: |
Thu, 16 Sep 2021 17:12:36 +0200 |
From: Peter Maydell <peter.maydell@linaro.org>
Trim down the #includes in qemu.h where we can, either by
dropping unneeded headers or by moving them to user-internals.h.
This includes deleting a couple of #includes that appear at
weird points midway through the header file.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210908154405.15417-10-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/qemu.h | 4 ----
linux-user/user-internals.h | 2 ++
thunk.c | 1 +
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/linux-user/qemu.h b/linux-user/qemu.h
index fda90fc28d68..5c713fa8ab26 100644
--- a/linux-user/qemu.h
+++ b/linux-user/qemu.h
@@ -2,7 +2,6 @@
#define QEMU_H
#include "cpu.h"
-#include "exec/exec-all.h"
#include "exec/cpu_ldst.h"
#undef DEBUG_REMAP
@@ -163,8 +162,6 @@ typedef struct TaskState {
struct target_sigaltstack sigaltstack_used;
} __attribute__((aligned(16))) TaskState;
-#include "qemu/log.h"
-
abi_long do_brk(abi_ulong new_brk);
/* user access */
@@ -349,5 +346,4 @@ void *lock_user_string(abi_ulong guest_addr);
#define unlock_user_struct(host_ptr, guest_addr, copy) \
unlock_user(host_ptr, guest_addr, (copy) ? sizeof(*host_ptr) : 0)
-#include <pthread.h>
#endif /* QEMU_H */
diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
index 1729a8b62e18..661612a088b5 100644
--- a/linux-user/user-internals.h
+++ b/linux-user/user-internals.h
@@ -20,6 +20,8 @@
#include "hostdep.h"
#include "exec/user/thunk.h"
+#include "exec/exec-all.h"
+#include "qemu/log.h"
extern char *exec_path;
void init_task_state(TaskState *ts);
diff --git a/thunk.c b/thunk.c
index fc5be1a502e7..dac4bf11c65b 100644
--- a/thunk.c
+++ b/thunk.c
@@ -17,6 +17,7 @@
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "qemu.h"
#include "exec/user/thunk.h"
--
2.31.1
- [PULL 00/10] Linux user for 6.2 patches, Laurent Vivier, 2021/09/16
- [PULL 03/10] linux-user: Split signal-related prototypes into signal-common.h, Laurent Vivier, 2021/09/16
- [PULL 07/10] linux-user: Split linux-user internals out of qemu.h, Laurent Vivier, 2021/09/16
- [PULL 01/10] linux-user: Fix coding style nits in qemu.h, Laurent Vivier, 2021/09/16
- [PULL 04/10] linux-user: Split loader-related prototypes into loader.h, Laurent Vivier, 2021/09/16
- [PULL 06/10] linux-user: Split safe-syscall macro into its own header, Laurent Vivier, 2021/09/16
- [PULL 02/10] linux-user: Split strace prototypes into strace.h, Laurent Vivier, 2021/09/16
- [PULL 05/10] linux-user: Split mmap prototypes into user-mmap.h, Laurent Vivier, 2021/09/16
- [PULL 09/10] linux-user: Drop unneeded includes from qemu.h,
Laurent Vivier <=
- [PULL 10/10] linux-user: Check lock_user result for ip_mreq_source sockopts, Laurent Vivier, 2021/09/16
- [PULL 08/10] linux-user: Don't include gdbstub.h in qemu.h, Laurent Vivier, 2021/09/16
- Re: [PULL 00/10] Linux user for 6.2 patches, Peter Maydell, 2021/09/17