Re: [PATCH v6 02/21] target/loongarch: Add core definition

[Richard Henderson]

On 9/17/21 1:12 AM, Song Gao wrote:
> +static bool loongarch_cpu_has_work(CPUState *cs)
> +{
> +    return true;
> +}

Note that this function will shortly disappear for user-only.

> +static bool loongarch_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> +                       MMUAccessType access_type, int mmu_idx,
> +                       bool probe, uintptr_t retaddr)
> +{
> +    LoongArchCPU *cpu = LOONGARCH_CPU(cs);
> +    CPULoongArchState *env = &cpu->env;
> +
> +    env->badaddr = address;
> +    cs->exception_index = EXCP_ADE;
> +    do_raise_exception(env, cs->exception_index, retaddr);
> +}

As will this.  But in the meantime,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~