Re: [PATCH v2 29/30] accel/tcg/user-exec: Implement CPU-specific signal handler for loongarch64 hosts

[Richard Henderson]

On 9/21/21 1:19 PM, WANG Xuerui wrote:
> +        case 0b00011111110: /* stle.w */
> +        case 0b00011111111: /* stle.d */
> +            is_write = 1;
> +            break;
> +        default:
> +            /* test for am* instruction range */
> +            if (0b00011000000 <= sel && sel <= 0b00011100011) {
> +                is_write = 1;
> +            }

Probably better to fold the range check into the switch with

  case 0b00011000000 ... 0b00011100011:  /* am* insn range */

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~