qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 16/23] target/i386/sev: Remove stubs by using code elision


From: Paolo Bonzini
Subject: Re: [PATCH v4 16/23] target/i386/sev: Remove stubs by using code elision
Date: Fri, 8 Oct 2021 13:46:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

On 07/10/21 19:22, Dr. David Alan Gilbert wrote:
So that I'm fine with, the bit I'm more worried about is the bit where
inside the if () we call functions (like sev_get_cbit_position )  which
we know the compiler will elide; I'm sure any sane compiler will,
but.....

Looking at your example, in cpu.c there's still places that ifdef around
areas with tcg_enabled.

I think that's just because nobody tried changing it; it should work there as well.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]