Re: [PATCH v2 1/6] target/riscv: zfh: half-precision load and store

qemu-devel

From:	Richard Henderson
Subject:	Re: [PATCH v2 1/6] target/riscv: zfh: half-precision load and store
Date:	Fri, 15 Oct 2021 13:37:56 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/15/21 12:03 AM, frank.chang@sifive.com wrote:

+#define REQUIRE_ZFH(ctx) do { \
+    if (!ctx->ext_zfh)        \
+        return false;         \
+} while (0)


Missing braces for if.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Current Thread

[Next in Thread]

[PATCH v2 0/6] target/riscv: support Zfh, Zfhmin extension v0.1, frank . chang, 2021/10/15
- [PATCH v2 1/6] target/riscv: zfh: half-precision load and store, frank . chang, 2021/10/15
  - Re: [PATCH v2 1/6] target/riscv: zfh: half-precision load and store, Richard Henderson <=
- [PATCH v2 2/6] target/riscv: zfh: half-precision computational, frank . chang, 2021/10/15
  - Re: [PATCH v2 2/6] target/riscv: zfh: half-precision computational, Richard Henderson, 2021/10/15
- [PATCH v2 3/6] target/riscv: zfh: half-precision convert and move, frank . chang, 2021/10/15
  - Re: [PATCH v2 3/6] target/riscv: zfh: half-precision convert and move, Richard Henderson, 2021/10/15
- [PATCH v2 4/6] target/riscv: zfh: half-precision floating-point compare, frank . chang, 2021/10/15
  - Re: [PATCH v2 4/6] target/riscv: zfh: half-precision floating-point compare, Richard Henderson, 2021/10/15
- [PATCH v2 5/6] target/riscv: zfh: half-precision floating-point classify, frank . chang, 2021/10/15
  - Re: [PATCH v2 5/6] target/riscv: zfh: half-precision floating-point classify, Richard Henderson, 2021/10/15
- [PATCH v2 6/6] target/riscv: zfh: implement zfhmin extension, frank . chang, 2021/10/15
  - Re: [PATCH v2 6/6] target/riscv: zfh: implement zfhmin extension, Richard Henderson, 2021/10/15