Re: [PATCH 04/31] target/loongarch: Add basic vmstate description of CPU.

[Richard Henderson]

On 10/19/21 12:34 AM, Xiaojuan Yang wrote:
> +#ifndef CONFIG_USER_ONLY
> +#include "hw/core/sysemu-cpu-ops.h"
> +
> +static const struct SysemuCPUOps loongarch_sysemu_ops = {
> +    .legacy_vmsd = &vmstate_loongarch_cpu,
> +};
> +#endif
The documentation for legacy_vmsd is quite clear:

    Do not use in new targets, use #DeviceClass::vmsd instead.

> +/* LoongArch CPU state */
> +
> +const VMStateDescription vmstate_loongarch_cpu = {
> +    .name = "cpu",
> +    .version_id = 20,
> +    .minimum_version_id = 20,

Version id should start at 0.


r~