Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree

From:	Richard Henderson
Subject:	Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree
Date:	Sat, 23 Oct 2021 18:53:53 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/23/21 2:47 PM, Philippe Mathieu-Daudé wrote:

+static bool trans_LDI(DisasContext *ctx, arg_msa_ldst *a)
+{
+    TCGv_i32 tdf;
+    TCGv_i32 twd;
+    TCGv_i32 timm;
+
+    if (!check_msa_access(ctx)) {
+        return false;
+    }


Return true.  I won't mention the return after check_msa_access again.

+    twd = tcg_const_i32(a->wd);
+    timm = tcg_const_i32(a->sa);


tcg_constant_i32.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 02/33] target/mips: Fix MSA MADDV.B opcode, (continued)
- [PATCH 02/33] target/mips: Fix MSA MADDV.B opcode, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 03/33] target/mips: Fix MSA MSUBV.B opcode, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 04/33] tests/tcg/mips: Run MSA opcodes tests on user-mode emulation, Philippe Mathieu-Daudé, 2021/10/23
- [PATCH 05/33] target/mips: Have check_msa_access() return a boolean, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 05/33] target/mips: Have check_msa_access() return a boolean, Richard Henderson, 2021/10/23
- [PATCH 06/33] target/mips: Use enum definitions from CPUMIPSMSADataFormat enum, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 06/33] target/mips: Use enum definitions from CPUMIPSMSADataFormat enum, Richard Henderson, 2021/10/23
- [PATCH 07/33] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 07/33] target/mips: Rename sa16 -> sa, bz_df -> bz -> bz_v, Richard Henderson, 2021/10/23
- [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree, Richard Henderson <=
- [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers, Richard Henderson, 2021/10/23
- [PATCH 10/33] target/mips: Extract df_extract() helper, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 10/33] target/mips: Extract df_extract() helper, Richard Henderson, 2021/10/23
- [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 11/33] target/mips: Convert MSA I5 instruction format to decodetree, Richard Henderson, 2021/10/23
- [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 12/33] target/mips: Convert MSA BIT instruction format to decodetree, Richard Henderson, 2021/10/23
- [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/23
  - Re: [PATCH 13/33] target/mips: Convert MSA SHF opcode to decodetree, Richard Henderson, 2021/10/23

Prev by Date: Re: [PATCH v8 07/10] ACPI ERST: create ACPI ERST table for pc/x86 machines
Next by Date: Re: [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers
Previous by thread: [PATCH 08/33] target/mips: Convert MSA LDI opcode to decodetree
Next by thread: [PATCH 09/33] target/mips: Introduce generic TRANS_CHECK() for decodetree helpers
Index(es):
- Date
- Thread