[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] trace: inroduce qmp: trace namespace
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 0/5] trace: inroduce qmp: trace namespace |
Date: |
Tue, 26 Oct 2021 12:28:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Stefan Hajnoczi <stefanha@redhat.com> writes:
> On Thu, Oct 14, 2021 at 06:22:32PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> 12.10.2021 14:49, Markus Armbruster wrote:
>> > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
[...]
>> Another possible way is to update QAPI code generator to insert a personal
>> trace point for each qmp command.. That seems more complicated to implement,
>> but I can try.
>
> That's what came to mind when I saw this series too. The QAPI generator
> can create a trace event for each QMP command. That way each command has
> a dedicated trace event that can be enabled/disabled in the usual way
> (e.g. built-in "trace" monitor command, SystemTap scripts, etc) without
> introducing special syntax.
I like how this way stays entirely within the existing interface. I
couldn't tell you how to implement it, though :)